admin2/manual_teachbooks
1
0
Fork 0
mirror of https://github.com/TeachBooks/manual.git synced 2026-11-12 22:35:51 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

Refactor directive name construction for clarity

Browse source 
Extracted suffix_separator, suffix_start, and suffix_end from cfg to local variables for improved readability and maintainability in directive name construction.
This commit is contained in:
Dennis den Ouden-van der Horst 2026-01-03 12:50:11 +01:00
parent e12183af9e
commit 1ac94844a3
1 changed files with 5 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

7
book/_ext/sphinx_gated_directives/__init__.py
View file

@ -249,9 +249,12 @@ def _register_new_directives(app, env, docnames):
snapshot_names = set(unified.keys())
added = 0
suffix_separator = cfg["suffix_separator"]
suffix_start = cfg["suffix_start"]
suffix_end = cfg["suffix_end"]
for orig_name, obj in sorted(unified.items()):
new_name = f"{orig_name}{cfg["suffix_separator"]}{cfg["suffix_start"]}"
new_name = f"{orig_name}{suffix_separator}{suffix_start}"
# add start and end directives if not already present, or if override is requested explicitly
if new_name in snapshot_names:
if isinstance(cfg["override_existing"], bool):
@ -260,7 +263,7 @@ def _register_new_directives(app, env, docnames):
else:
if orig_name not in cfg["override_existing"]:
continue
end_name = f"{orig_name}{cfg["suffix_separator"]}{cfg["suffix_end"]}"
end_name = f"{orig_name}{suffix_separator}{suffix_end}"
if end_name in snapshot_names:
if isinstance(cfg["override_existing"], bool):
if cfg["override_existing"] is False: