From 1ac94844a33e1a9ee12a7e956c01e9fb0900d385 Mon Sep 17 00:00:00 2001 From: Dennis den Ouden-van der Horst Date: Sat, 3 Jan 2026 12:50:11 +0100 Subject: [PATCH] Refactor directive name construction for clarity Extracted suffix_separator, suffix_start, and suffix_end from cfg to local variables for improved readability and maintainability in directive name construction. --- book/_ext/sphinx_gated_directives/__init__.py | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/book/_ext/sphinx_gated_directives/__init__.py b/book/_ext/sphinx_gated_directives/__init__.py index f85538a..5aef914 100644 --- a/book/_ext/sphinx_gated_directives/__init__.py +++ b/book/_ext/sphinx_gated_directives/__init__.py @@ -249,9 +249,12 @@ def _register_new_directives(app, env, docnames): snapshot_names = set(unified.keys()) added = 0 + suffix_separator = cfg["suffix_separator"] + suffix_start = cfg["suffix_start"] + suffix_end = cfg["suffix_end"] for orig_name, obj in sorted(unified.items()): - new_name = f"{orig_name}{cfg["suffix_separator"]}{cfg["suffix_start"]}" + new_name = f"{orig_name}{suffix_separator}{suffix_start}" # add start and end directives if not already present, or if override is requested explicitly if new_name in snapshot_names: if isinstance(cfg["override_existing"], bool): @@ -260,7 +263,7 @@ def _register_new_directives(app, env, docnames): else: if orig_name not in cfg["override_existing"]: continue - end_name = f"{orig_name}{cfg["suffix_separator"]}{cfg["suffix_end"]}" + end_name = f"{orig_name}{suffix_separator}{suffix_end}" if end_name in snapshot_names: if isinstance(cfg["override_existing"], bool): if cfg["override_existing"] is False: